GoTo Error

[Yegg]

im trying to make it so that in my bot you can open a text document through a menu, like mnutxtChan should open up channels.txt, hers my code:

Private Sub mnuUserstxt_Click()
On Error GoTo Error
  ShellExecute Me.hWnd, vbNullString, App.Path & "\users.txt", vbNullString, "C:\", SW_SHOWNORMAL
Error:
MsgBox "Could not find users.txt!"
End Sub

i want this to work so that if the txt document is not found the message box wil pop up. so far, when the txt document isn't found it comes up, but it also comes up when the txt document is found. can ne1 help me?

[drivehappy]

Code Select Expand


Private Sub mnuUserstxt_Click()
If Dir$("C:\users.txt") = "" Then
        MsgBox "Could not find users.txt!"
Else
        ShellExecute Me.hWnd, vbNullString, App.Path & "\users.txt", vbNullString, "C:\",  SW_SHOWNORMAL
End If
End Sub

EDIT: code tags

[Yegg]

ok, wel theres a problem with that code, no matter wut happens the message box pops up.

[CrAz3D]

Did you notice the directory that drivehappy used?... C:\...unless your application's directory is C:\ also it will not work.

[Yegg]

then how would i get the bot to look for that file in its current directory?
Is there a way i could use App.Path?

[Dyndrilliac]

Code Select Expand

If Dir$(App.Path & "\users.txt") = vbNullString Then

[UserLoser.]

im trying to make it so that in my bot you can open a text document through a menu, like mnutxtChan should open up channels.txt, hers my code:

Private Sub mnuUserstxt_Click()
On Error GoTo Error
  ShellExecute Me.hWnd, vbNullString, App.Path & "\users.txt", vbNullString, "C:\", SW_SHOWNORMAL
Error:
MsgBox "Could not find users.txt!"
End Sub

i want this to work so that if the txt document is not found the message box wil pop up. so far, when the txt document isn't found it comes up, but it also comes up when the txt document is found. can ne1 help me?

It's coming up because the next routine is at Error.  If you put Exit Sub after the ShellExecute, it wouldn't.  But on an error, it'll still say "Could not find users.txt!"

[Dyndrilliac]

im trying to make it so that in my bot you can open a text document through a menu, like mnutxtChan should open up channels.txt, hers my code:

Private Sub mnuUserstxt_Click()
On Error GoTo Error
  ShellExecute Me.hWnd, vbNullString, App.Path & "\users.txt", vbNullString, "C:\", SW_SHOWNORMAL
Error:
MsgBox "Could not find users.txt!"
End Sub

i want this to work so that if the txt document is not found the message box wil pop up. so far, when the txt document isn't found it comes up, but it also comes up when the txt document is found. can ne1 help me?

It's coming up because the next routine is at Error.  If you put Exit Sub after the ShellExecute, it wouldn't.  But on an error, it'll still say "Could not find users.txt!"

Goto is evil though.

[Yegg]

ok, now i have:

On Error GoTo Error
  ShellExecute Me.hWnd, vbNullString, App.Path & "\users.txt", vbNullString, "C:\", SW_SHOWNORMAL
Exit Sub
Error:
MsgBox "Could not find users.txt!"

this opens the txt document but when its not found, nothing happens

[UserLoser.]

ok, now i have:

On Error GoTo Error
  ShellExecute Me.hWnd, vbNullString, App.Path & "\users.txt", vbNullString, "C:\", SW_SHOWNORMAL
Exit Sub
Error:
MsgBox "Could not find users.txt!"

this opens the txt document but when its not found, nothing happens

If it doesn't exist, you can't open it.

[Yegg]

i know this, i want the msgbox to come up when it doesn't exist and some1 tries to open it.

[Dyndrilliac]

Most non void type API functions return a value of zero when they fail. Try:

Code Select Expand

If ShellExecute(Me.hWnd, vbNullString, App.Path & "\users.txt", vbNullString, "C:\", SW_SHOWNORMAL) = 0 Then MsgBox "There is no file dumbass." Else Exit Sub

Of course that works on the assumption this API works the same as most others. You could search MSDN to see if it returns anything in the case that it errors.

[UserLoser.]

Example:

Code Select Expand


Dim ErrorCode As Long

ErrorCode = ShellExecute(hWnd, vbNullString, App.Path & "\Users.txt", vbNullString, vbNullString, SW_SHOWNORMAL)

Select Case ErrorCode
    Case Is > 32:
        'Successfully executed
    Case 0, SE_ERR_OOM:
        'We're out of memory
    Case ERROR_FILE_NOT_FOUND, SE_ERR_FNF:
        'File isn't found
    Case SE_ERR_ACCESSDENIED:
        'Access denied
    Case SE_ERR_SHARE:
        'Sharing violation

    '*Todo: _YOU_ finish handling, see MSDN*

    Case Else:
        'Unrecognized error, this shouldn't happen
End Select


ShellExecute

[Grok]

Just check if the file exists before trying to launch it?  I prefer FileSystemObject.  Go to project references, check the box beside "Microsoft Scripting Runtime".  Then ...

Code Select Expand


Private fso as New Scripting.FileSystemObject
'....
If fso.FileExists(fso.BuildPath(App.Path, "users.txt")) = False Then
    MsgBox "File not found!", vbExclamation, "Missing file, duh."
Else
    ErrorCode = ShellExecute(hWnd, vbNullString, App.Path & "\Users.txt", vbNullString, vbNullString, SW_SHOWNORMAL)
End If


[phvckmeh]

this is what i do to open txt files

Code Select Expand


Dim strPath as string
Shell "notepad " & strPath, vbNormalFocus


it always works.