Changing password..

[vuther.de]

I have no idea why this is not working, i've tried everything i can think of, but it still just stops and does nothing, not ipban me, or nothing. Here is what i have:

Code Select Expand

Case &H51 ' SID_AUTH_CHECK '
           
           Select Case pbuffer.GetWORD(Mid$(strData, 5, 2))
               
               Case &H0
                If Setting.chkbotplug.Value <> vbChecked Then
                       With pbuffer
                           .InsertNonNTString "tenb"
                           .sendPacket &H14
                           .sendPacket &H2D
                       End With
                   End If
                If Setting.ChangePass.Value = vbChecked Then
                AddChat vbGreen, "Attempting to change password..."
                Call ChangePassword(Setting.txtNewPass.Text, Setting.txtpassword.Text, Setting.txtUsername.Text)
                Setting.txtNewPass.Text = ""
                WriteStuff "Login", "NewPass", ""
                Setting.ChangePass.Value = vbUnchecked
                WriteStuff "Login", "ChangePass", "0"
                End If
                   If strProduct = "3RAW" Or strProduct = "PX3W" Then
                       With pbuffer
                           .InsertNTString strUsername
                           .InsertNTString strPassword
                           .sendBNRHSPacket BNRHS_AUTHACCOUNTLOGON
                       End With
                   Else
                       With pbuffer
                           .InsertNTString strUsername
                           .InsertNTString strPassword
                           .sendBNRHSPacket BNRHS_0x3A
                       End With
                   End If
                AddChat &H808080, "Checking verison and cdkey..."

Case &H31 ' Password Change '
               If InStr(strData, Chr(&H1)) Then
                   AddC vbGreen, "Password change successful!"
                   With pbuffer
                           .InsertNTString strUsername
                           .InsertNTString strPassword
                           .sendBNRHSPacket BNRHS_0x3A
                    End With
               Else
                   AddC vbRed, "Password change failed!"
               End If

Public Sub ChangePassword(strnewpass As String, strcurrentpass As String, strUsername As String)
Dim strAccountHash As String
Dim Result As Long
Dim outbuf As String
Dim RP As Long
   strAccountHash = String(5 * 4, vbNullChar)
   Result = X(strAccountHash, strnewpass)
   outbuf = String(7 * 4, vbNullChar)
   RP = A(outbuf, lngservers, strcurrentpass)
   
   With pbuffer
       .InsertNonNTString outbuf
       .InsertNonNTString strAccountHash
       .InsertNTString strUsername
       .sendPacket &H31
   End With
I hope you can figure it out. :/

Added code tags because they're pretty.
- Spht

[ChR0NiC]

*cough* code tags *cough*

Edit: Also have you tried packet logging? You might notice you are sending an empty value somewhere or a variable has been forgot to be set. Simple stuff like that gets people stuck all the time.

[BaDDBLooD]

*cough* code tags *cough*

Edit: Also have you tried packet logging? You might notice you are sending an empty value somewhere or a variable has been forgot to be set. Simple stuff like that gets people stuck all the time.

You might also want to Debug your code while your logging on, in order to see exactly what is in the strings etc.. that your sending.  That Along with packetlogging will surely provide a solution.

[UserLoser.]

WTF IS BNLS BNRHS?

[vuther.de]

Battle.net Remote Hashing Service, and no UserLoser, it's not a proxy off BNLS ;p

[Kp]

Battle.net Remote Hashing Service, and no UserLoser, it's not a proxy off BNLS ;p

Oh, so it's only a rip-off of the name and idea.  That's a much better solution!  However, if you're going to use it to steal user information, you'd have been better off proxying to BNLS, so that when you're accused of theft, you could just admit to being a BNLS proxy and blame it on us (at which point we could point to the thousands upon thousands of unstolen accounts, thereby discrediting you even further ).

[vuther.de]

I didn't make it.

[ChR0NiC]

You might also want to Debug your code while your logging on, in order to see exactly what is in the strings etc.. that your sending.  That Along with packetlogging will surely provide a solution.

Wow taking my answer and spicing it up, how nice

Also, iNNeR, posting code here and saying WHY DOESN'T THIS WORK is not a very good way of getting help, believe me. You are basically asking us to debug your code and giving us no information.

[BaDDBLooD]

You might also want to Debug your code while your logging on, in order to see exactly what is in the strings etc.. that your sending.  That Along with packetlogging will surely provide a solution.

Wow taking my answer and spicing it up, how nice

Also, iNNeR, posting code here and saying WHY DOESN'T THIS WORK is not a very good way of getting help, believe me. You are basically asking us to debug your code and giving us no information.

Sorry chronic.  I sort of Expanded on your answer in a way that might be of more help.  I didn't mean to offend you, if i did.

[Zakath]

Chronic, don't be so antagonistic. There was nothing wrong with BaDDBLooD's response.

[Eli_1]

Show us a hex dump of your bot sending that packet, and show us one of an actual client sending that packet (assuming you actually have the client).

[BaDDBLooD]

Also refer to http://bnetdocs.valhallalegends.com for the format of the change password packets

[ChR0NiC]

Also refer to http://bnetdocs.valhallalegends.com for the format of the change password packets

He hasn't responded in a while so either he fixed the problem or this topic no longer interests him. Just my opinion if it's ok with you Zakath.

[vuther.de]

I'm sorry i haven't responded, i got it working, thanks everyone for your support and help.