Recent BNLS changes

[Skywing]

Changes
-------

* Fixed an issue that caused BNLS_CONFIRMLOGON to randomly fail.
* Fixed an issue that caused the server to (very rarely) return incorrect NLS computational results that would typically manifest themselves as bogus failed logon attempts.
* Improved the performance of the version checking engine.
* Improved the performance of the NLS calculation engine.
* Improved worker thread load balancing (BNLS now runs on a multiprocessor machine).
* Updated the server signature checking algorithm to support recent security enhancements made by Blizzard.
* Updated the documentation to state that an NLS change and an NLS upgrade operation cannot be performed simultaneously with eachother or an NLS logon operation (note that BNLS has never permitted this).
* Various other internal changes to resolve stability and performance issues.

The logon/confirmlogon problems were both long-standing bugs.

[Stealth]

Link to the current protocol spec for interested parties: http://yoni.valhallalegends.com/BNLSProtocolSpec.txt

[Lenny]

* Updated the server signature checking algorithm to support recent security enhancements made by Blizzard.

What exactly were these new enhancements bnet added?
And when were they added?

[UserLoser.]

* Updated the server signature checking algorithm to support recent security enhancements made by Blizzard.

What exactly were these new enhancements bnet added?
And when were they added?

Most likely a patch or so ago

[Skywing]

* Updated the server signature checking algorithm to support recent security enhancements made by Blizzard.

What exactly were these new enhancements bnet added?
And when were they added?

The enhancements close a flaw that I discovered which could allow the signature to be spoofed.  They were implemented several patches ago.

[Skywing]

Fixed an issue that could cause BNLS to start rejecting version check requests (returning them with a failure status).  If you were unable to run version checks on BNLS early this morning, the problem has been resolved.

[Skywing]

Fixed the above bug again (due to a misconfiguration, the fix wasn't properly applied to the server the first time).  This time it should stay fixed...

[ChR0NiC]

Thanks Again SkyWing