Errors with declspec(naked) and fastcall function

[warz]

I've got a function in a class of mine defined like so..

Code Select Expand


int __fastcall GetMaximumSupply(int playerid, int raceid);
int __declspec(naked) __fastcall NativeClass::GetMaximumSupply(int playerid, int raceid) {}


The first is inside my class definition, and the second is in the relative cpp file for the class.
This function looks like...

Code Select Expand


const static DWORD offset_maxsupply = 0x00410a90;
int __declspec(naked) __fastcall NativeClass::GetMaximumSupply(int playerid, int raceid) {
     __asm {
jmp [offset_maxsupply]
     }
}


I am calling this function like..

Code Select Expand


global->native.PrintText(0xBE, (00 + (x * 10)), "%d", global->native.GetMaximumSupply(players[x].id, 0));


I am receiving an error message that states..



my question is pretty straightforward, because I don't know what else to say. :-p
anyways, does anyone know what im doing wrong? ive never attempted to make a declspec(naked), or fastcall function before - but this is calling a native brood war function and expecting an int return value.

[MyndFyre]

Why are you __declspec(naked)'ing that?

Chances are, the Brood War function is expecting its caller to do something that you're not doing, and whatever's calling you isn't doing it either because you're in a naked context.

[warz]

I just made it static, seems to fix it. :-p

Except for the function is only returning the correct max supply value for one player, even when I make everyone zerg and supply 0 for race id in a full game of all zerg players. It returns 0 for everyone else.

[Maddox]

I just made it static, seems to fix it. :-p

Except for the function is only returning the correct max supply value for one player, even when I make everyone zerg and supply 0 for race id in a full game of all zerg players. It returns 0 for everyone else.

Non-static, native, class functions use __thiscall by default, which is fastcall with the this pointer in ecx and edx unused.  Adding __fastcall to a method probably doesn't do anything unless the method is static.

For reference, if you want to hook a __thiscall function (there are lots in warcraft 3) you should use a function pointer like so:

Code Select Expand


typedef void (__fastcall * ptrFunc)(void * class, void * dummy, ...);


[Maddox]

Hey warz, what is your AIM/MSN now? Is it still dotslashwarz?