Inline asm issue in VC++ 6

[Yegg]

I'm just messing around with inline assembly in MS VC++ 6. Here is the code I am working on:

Code Select Expand

__asm {
mov eax, 0
push eax
call GetModuleHandle
mov [hInstance], eax
mov eax, [hInstance]
push eax
mov eax, IDD_MAINFORM
push eax
mov eax, NULL
push eax
mov eax, MainDlgProc
push eax
call DialogBoxParam
}

Now, the error I get is:

error C2400: inline assembler syntax error in 'second operand'; found ')'

Now, I'm not VC++ expert or asm expert, so I really have no clue why this would happen. For all I know the answer to this is very simple. I'm also not sure where this ')' is located when the error refers to it. Hopefully someone can help me out with this.

[MyndFyre]

Can you tell us at least which line?

I would guess IDD_MAINFORM since it's #defined in a resource file.  But telling us the line of the error may be helpful...

[Yegg]

Sorry about that. I meant to put which line, I just forgot. Here it is:

Code Select Expand

mov eax, NULL

[Hell-Lord]

This is just a wild guess but instead of NULL maybe 'False' ?

[Yegg]

This is just a wild guess but instead of NULL maybe 'false'
?

It just tells me that the label 'false' is undefined. Keep in mind that this is the first time I've ever tried messing with inline assembly, so I'm probably not doing something else that I should have done.

[MyndFyre]

Replace it with 0.  I'm thinking that NULL is in stdio.h:

Code Select Expand


#define NULL    ((void *)0)


[Hell-Lord]

Yep it is in the stdio.h header.

Just to my knowledge :

Code Select Expand

__asm ("assembly code");

Not sure what difference () will make instead of {}

Also i believe you can entirely remove 'NULL'
so it will look like

Code Select Expand

mov      eax

[MyndFyre]

Or as is a really common practice:

Code Select Expand


xor eax, eax


[Yegg]

Replacing NULL with 0 causes the application to crash upon execution. Doing xor eax, eax also causes the application to crash upon execution. I'm beginning to think that I've done something else wrong? I'll let you know if I figure anything out.

[Hell-Lord]

By the way is that an Intel Processor you have right?

[Barabajagal]

[Intel-based/X86/x64. Intel and AMD have the same base system, so saying Intel isn't quite the correct terminology.]

[Hell-Lord]

But i gather he knew.

[Barabajagal]

It's not about knowing, Paul, it's about terminology.

[Hell-Lord]

Thanks for the lesson Andy

Try:

Code Select Expand

mov      eax, edx

[Warrior]

Well..he could of been asking it he was using an intel processor, never mind the architecture.

But I am just being dense on purpose.