• Welcome to Valhalla Legends Archive.
 

The CSB VBScript PHP Webbot, v2!

Started by Joe[x86], September 05, 2005, 08:06 PM

Previous topic - Next topic

FrOzeN

#15
On this link you forgot to close the href= tags with the second quotation mark. Making the 'Use the Bot' link invisible and also screwing up the address of the 'View Source' link.

[EDIT] Also the code <link rel="stylesheet" type="text/css" href="Stylesheet.css" />, should be inside the <head> tags.
~ FrOzeN

rabbit

#16
Also, in the head comment, you have "* /", thus commenting the entire script.  Also, why not just use HTML comment tags (correctly)?

Later on (line 32), you have an incorrect HTML comment tag closer, it should be "//-->".
[update]  Same on line 137

Line 34 has an extra quote, making the rest of the script screwy.  DEBUG MAN!!

Lines 58 and 62 are missing PHP segment closers.

PHP uses a period for string concatenation, not an ampersand.

[edit]
You aren't in x86 anymore.
Grif: Yeah, and the people in the red states are mad because the people in the blue states are mean to them and want them to pay money for roads and schools instead of cool things like NASCAR and shotguns.  Also, there's something about ketchup in there.

dxoigmn

Quote from: rabbit on November 13, 2005, 09:07 AM
Later on (line 32), you have an incorrect HTML comment tag closer, it should be "//-->".

Umm...HTML comments are in the form <!-- comment -->  Looks like someone is trying to inject c++-style comments into html.

rabbit

Every syntax highlighter I've used only closed off comments after //--> :\
O well.
Grif: Yeah, and the people in the red states are mad because the people in the blue states are mean to them and want them to pay money for roads and schools instead of cool things like NASCAR and shotguns.  Also, there's something about ketchup in there.

MyndFyre

Quote from: rabbit on November 13, 2005, 06:01 PM
Every syntax highlighter I've used only closed off comments after //--> :\
O well.

That's for Javascript.  To support older browsers, Javascript specified that Javascript code should be contained within multiline HTML comments, and that when <!-- occured within <script> tags it should only be considered a single-line comment.  Also, so that --> wasn't tried to be parsed as Javascript, we comment it out with // first.

<script language="JavaScript">
<!-- Hide this code from older browsers
// blarg
alert("Boo!");
// End hiding and don't use the JS parser for this line -->
</script>
QuoteEvery generation of humans believed it had all the answers it needed, except for a few mysteries they assumed would be solved at any moment. And they all believed their ancestors were simplistic and deluded. What are the odds that you are the first generation of humans who will understand reality?

After 3 years, it's on the horizon.  The new JinxBot, and BN#, the managed Battle.net Client library.

Quote from: chyea on January 16, 2009, 05:05 PM
You've just located global warming.