Print Page - Sample Bot

Title: Sample Bot
Post by: ILurker on April 16, 2003, 09:33 PM

Finally, I have taken some time to modify samplebot from the last patch, and release it.

Samplebot:
[Starcraft & Brood War Only]

Download:...
http://www.wolfness.com/simi/chaosbot/samplebot.zip

Feel free to rip this off all you want, I don't care.

Title: Re:Sample Bot
Post by: TheMinistered on April 16, 2003, 10:16 PM

I want to thank you for posting an example, good job! however, before even opening, I prophicy that I will end up posting correctiong/tips, first thing I see are naming conventions are _horrible_ but thats okay you can work on them, these are all things to help you out, don't take them the wrong way. Take them and use them to improve further.

[edit 1]
Please do not put things like ...

Code Select


'Sample Bot By: iLurker'

Then not give credit to authors of other parts of your source. You are misleading people who read the source code. If there is any doubt in who wrote it, I could consider it plagiarism.

[edit 2]
If you are going to take a modular approach (Yes, I see your class modules, but the majority of the project is modular, and what class modules that do appear in his project appear to be the works of others) then please name modules according to what would be contained. Try breaking the code up into modules, each module handling different things. Then place the functions/subs into the corresponding modules. I'm sure you _all_ know this already though, so enough said.

[edit 3]
Please try to keep a constant coding style through out the project. From looking at all the files contained in the project, each one contains a various flavor of coding. While this does proove that some of the code isn't yours, it also decreases readability (cough no 1337 chat coding cough). Try to improve here.

[edit 4]
Try to atleast make some optimizations, there are tons out there.

Title: Re:Sample Bot
Post by: Camel on April 17, 2003, 12:45 AM

[edit 1]
don't _ever_ apologize before you've done anything wrong

Title: Re:Sample Bot
Post by: Mesiah / haiseM on April 17, 2003, 01:04 AM

Code Select

pbuffer.InsertNTString "BinaryGateway"

i thought this code looked familiar...

Title: Re:Sample Bot
Post by: ILurker on April 17, 2003, 09:59 AM

I needed a little help with some parts of the bot :-\

Title: Re:Sample Bot
Post by: Banana fanna fo fanna on April 20, 2003, 03:48 PM

ILurker: WHERE THE HELL DID YOU GET MY SOURCE FROM?

Title: Re:Sample Bot
Post by: Fr0z3N on April 20, 2003, 05:44 PM

st0rm your source?

i havent loked at that one yet, no time!

Title: Re:Sample Bot
Post by: Mesiah / haiseM on April 20, 2003, 07:41 PM

QuoteILurker: WHERE THE HELL DID YOU GET MY SOURCE FROM?

lmao@that

Title: Re:Sample Bot
Post by: Banana fanna fo fanna on April 20, 2003, 08:02 PM

Most likely Ethbot or some version of BG...

Title: Re:Sample Bot
Post by: Etheran on April 21, 2003, 12:14 AM

*whistles innocently*

Edit: Module3.bas is a direct copy and paste from ethbot, no modification or anything that I can tell.

Edit2: Good to see my ReverseString algorithm in use in Module4.bas. :D

Title: Re:Sample Bot
Post by: FyRe on April 21, 2003, 12:45 AM

eww @ profile

Title: Re:Sample Bot
Post by: Camel on April 21, 2003, 09:21 AM

Quote from: Etheran on April 21, 2003, 12:14 AMEdit2: Good to see my ReverseString algorithm in use in Module4.bas. :D

just use StrReverse...

Valhalla Legends Archive

Programming => Battle.net Bot Development => Topic started by: ILurker on April 16, 2003, 09:33 PM